Skip to content

core/services/gateway/monitoring: preserve DON shard metric identity - #23572

Open
cfal wants to merge 1 commit into
developfrom
fix-don-shard-identity
Open

core/services/gateway/monitoring: preserve DON shard metric identity#23572
cfal wants to merge 1 commit into
developfrom
fix-don-shard-identity

Conversation

@cfal

@cfal cfal commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Gateway connection metrics use a datapoint-level donID that collides with the resource-level gateway donID, collapsing multiple DON shards into one series. This renames the datapoint attribute to donShardID.

@github-actions

Copy link
Copy Markdown
Contributor

👋 cfal, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

pavel-raykov
pavel-raykov previously approved these changes Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 28, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants