Repository navigation
fix: bump ACadSharp to 3.8.35 to tolerate duplicate DXF table entries - #11
Merged
Merged
Conversation
…ntries DXF files exporting both CONTINUOUS and Continuous linetypes crashed the reader with "An item with the same key has already been added". Upstream commit bbc638a1 keeps the first definition of a duplicated table entry (failsafe mode, on by default) instead of throwing.
Reproduction for the reader crash fixed by the ACadSharp 3.8.35 bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTINUOUSandContinuouslinetypes) crashedDxfReaderwith "An item with the same key has already been added".Directory.Packages.props, which includes upstream commitbbc638a1(keep the first definition of a duplicated DXF table entry under failsafe mode, on by default).Samples/SCD-085-035-100-AP3N-IS.dxf.Test plan
dotnet build ACadSharp.Image.sln -c Release --no-restore -warnaserrorclean on net6.0/net8.0/net10.0dotnet test— 463 passed, golden baselines intactcad-to-image Samples/SCD-085-035-100-AP3N-IS.dxf --width 300 --height 200 --hide-layer OPTIONAL_DIMENSIONSrenders PNG and SVG;--list-layersresolves linetypes