Skip to content

Fix Windows CI: pin windows-2022 -- new image's clang-cl 22 rejects bundled SDL's _m_prefetch #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arekbr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Windows CI: pin windows-2022 -- new image's clang-cl 22 rejects bundled SDL's _m_prefetch #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/build-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,16 @@ on:

jobs:
build-windows:
runs-on: windows-latest
# Pinned: windows-latest now resolves to the Windows Server 2025 / VS 2026
# image, whose bundled clang-cl is >= 21 and defines _m_prefetch as a builtin.
# MTEngineSDL's bundled SDL 2.28.5 header (SDL_endian.h) redefines it under
# plain "#ifdef __clang__", which is now a hard error:
# SDL_endian.h(40,1): error : definition of builtin function '_m_prefetch'
# windows-2022 ships VS 2022 (clang-cl 19.x, servicing-only, so it will stay
# < 21). The proper fix is upstream SDL's one-line guard change in the
# bundled header (MTEngineSDL repo); once that lands, this pin can go back
# to windows-latest.
runs-on: windows-2022

steps:
- name: Checkout RetroDebugger
Expand Down
Loading