Fix Linux build on master: add missing CDebuggerApi::GetWarpSpeed() referenced by #114 - #117
Fix Linux build on master: add missing CDebuggerApi::GetWarpSpeed() referenced by #114#117arekbr wants to merge 1 commit into
Conversation
My mistake when splitting the original work into separate PRs: the warp/get endpoint hunk in CDebuggerServerApi.cpp went into slajerek#114 (the commits were split by file, and that file carried changes belonging to two topics), while the CDebuggerApi::GetWarpSpeed() it calls stayed in the still-open slajerek#116. With slajerek#114 and slajerek#115 merged and slajerek#116 not, master does not compile on Linux: CDebuggerServerApi.cpp:112: error: 'class CDebuggerApi' has no member named 'GetWarpSpeed'; did you mean 'SetWarpSpeed'? This adds just that method (declaration + trivial forward to the existing CDebugInterface::GetSettingIsWarpSpeed), nothing else. Verified: master + this patch builds clean on Debian 13 / GCC 14. Note: the macOS and Windows CI failures on the same runs are unrelated to the merged PRs -- macOS dies in MTEngineSDL's Libtool step (Xcode 26.6 runner image), Windows in bundled SDL's SDL_endian.h (_m_prefetch builtin clash). Details in a comment on the run.
|
Verified on real hardware since opening this:
|
|
CI results across the three PRs confirm all three fixes -- each run now fails only on what its branch does not contain:
The last open question from #118 is settled by its own run: on macos-26-arm64 / Xcode 26.6 the So: merge this one first, then #118 and #119 (any order) -- after all three, master should be green on all platforms. |
|
Final proof, measured rather than argued: I merged all three PRs (#117 + #118 + #119) into one test branch on my fork (
Release artifacts got produced on all three. So after merging the three PRs, master goes green everywhere. |
Sorry -- this one is on me. When I split the original branch into three PRs, the split went by file, and
CDebuggerServerApi.cppcarried hunks belonging to two topics: thewarp/getendpoint landed in #114, while theCDebuggerApi::GetWarpSpeed()method it calls stayed in the still-open #116. With #114 and #115 merged and #116 paused, master fails on Linux:This PR adds exactly that method -- declaration plus a trivial forward to the existing
CDebugInterface::GetSettingIsWarpSpeed()-- and nothing else. Verified:master+ this patch builds clean on Debian 13 / GCC 14. Once merged, #116 will be rebased so the hunk does not appear twice.The macOS and Windows failures on the same CI runs are a different story and predate nothing in the merged code:
Libtool libMTEngineSDL.astep -- Apple libtool from the Xcode 26.6 runner image prints its Usage banner, i.e. it no longer accepts one of the passed flags. Neither merged PR touches MTEngineSDL or the Xcode project.SDL_endian.h(40,1): error: definition of builtin function '_m_prefetch'-- a known bundled-SDL2-vs-newer-MSVC clash, again in files the PRs do not touch.The last green CI run on master was in June; the runner images have moved since, so these two would have failed on any push. I am digging into both and will follow up.
🤖 Generated with Claude Code