Skip to content

fix: ignore development version suffixes when checking for updates #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 2 commits into from
Oct 28, 2026
Merged

fix: ignore development version suffixes when checking for updates #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78d9942
fix: ignore development version suffixes when checking for updates
zimeg Oct 27, 2026
051bf35
Merge branch 'main' into zimeg-fix-update-dev-version
mwbrooks Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/update/semver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,15 @@
package update

import (
"strings"

"golang.org/x/mod/semver"

"github.com/slackapi/slack-cli/internal/slackerror"
)

// SemVerGreaterThan returns true if release is greater than current
// SemVerGreaterThan returns true if release is greater than current, ignoring
// prerelease and development suffixes of current
func SemVerGreaterThan(release string, current string) (bool, error) {
r := ensureVPrefix(release)
c := ensureVPrefix(current)
Expand All @@ -32,6 +35,7 @@ func SemVerGreaterThan(release string, current string) (bool, error) {
return false, slackerror.New(slackerror.ErrInvalidSemVer).
WithMessage("Value %s is not a semantic version", current)
}
c = strings.TrimSuffix(semver.Canonical(c), semver.Prerelease(c))
return semver.Compare(r, c) > 0, nil
}

Expand Down
15 changes: 15 additions & 0 deletions internal/update/semver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,21 @@ func Test_Update_SemVerGreaterThan(t *testing.T) {
v2: "2.0.1",
expected: false,
},
"same release of a development build is not greater": {
v1: "v4.11.0",
v2: "v4.11.0-9-g154975a",
expected: false,
},
"newer release of a development build is greater": {
v1: "v4.12.0",
v2: "v4.11.0-9-g154975a",
expected: true,
},
"same release of a feature build is not greater": {
v1: "v4.11.0",
v2: "v4.11.0-example-feature",
expected: false,
},
"invalid first version errors": {
v1: "dev",
v2: "2.0.1",
Expand Down
Loading