Repository navigation
chore: floor certifi at 2026.10.19 in tutorial and test requirements - #1995
Merged
Merged
Conversation
…est requirements Adds certifi>=2026.10.19 to the PythOnBoardingBot tutorial requirements and to requirements/testing.txt (boto3/botocore verify TLS with certifi). Library runtime deps and python_requires are unchanged. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
Thanks for the contribution! Before we can merge this, we need @davidmreed to sign the Salesforce Inc. Contributor License Agreement. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
=======================================
Coverage 84.35% 84.35%
=======================================
Files 118 118
Lines 13793 13793
=======================================
Hits 11635 11635
Misses 2158 2158 ☔ View full report in Codecov by Harness. |
zimeg
changed the title
mwbrooks
approved these changes
Oct 26, 2026
zimeg
approved these changes
Oct 26, 2026
zimeg
left a comment
zimeg
left a comment
Member
There was a problem hiding this comment.
🧪 LGTM! Thanks @davidmreed for landing this here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
tutorial/PythOnBoardingBot/requirements.txt:certifi->certifi>=2026.10.19.requirements/testing.txt: addscertifi>=2026.10.19next toboto3<=2. This file is CI/test-only; botocore verifies TLS with certifi.pyproject.tomlruntime deps, theoptionalextra (requirements/optional.txt) andpython_requiresare unchanged.Where it ships
.github/workflows/pypi-release.yml:29,63) has no runtime deps (pyproject.toml:7) and uses stdlibssl.create_default_context()(slack_sdk/socket_mode/builtin/internals.py:43), i.e. the OS trust store, so the library itself is not changed here.requirements/testing.txtis installed by CI (.github/workflows/ci-build.yml:86,151) andscripts/install.sh:10. boto3 is atrequirements/testing.txt:41.tutorial/PythOnBoardingBot/requirements.txt:3).Not covered by this PR
optionalextra (boto3 inrequirements/optional.txt:23) is a consumer range and is intentionally not touched. Consumers using boto3 should pick up certifi 2026.10.19 in their own environments.Verification
pip install --dry-run --reportofrequirements/testing.txtandtutorial/PythOnBoardingBot/requirements.txtinpython:3.7-slimandpython:3.13-slim: both resolvecertifi==2026.10.19(certifi 2026.10.19 declaresRequires-Python >=3.7, so the oldest CI matrix row still resolves).🤖 Generated with Claude Code
Part of the eMudhra 53119 CA-distrust remediation (CVE-2026-111943).