Skip to content

🐀 Nightly Canary: upcoming-toolchain regression β€” e954c33Β #613

Closed

Description

@github-actions

🐀 Nightly Canary failed on main

Field Value
Workflow 🐀 Nightly Canary
Run #17
Attempt 1
Branch main
Commit e954c33
Triggered by @githubrobbi

Filed by ci-failure-notify.yml after the 60-second auto-rerun-transient window: auto-rerun-transient saw no transient signature in the failed-job logs β†’ genuine failure on first attempt.

⚠️ This is an early-warning signal from the floating-nightly canary, not a broken pin. main still builds on the pinned toolchain. Investigate before the next pin bump; if it is an upstream/dep regression, the fix is usually a dependency bump (cf. the ethnum 1.5.2β†’1.5.3 episode), not a toolchain downgrade.

πŸ“§ Notification sent to: cifail@uffs.io

Activity

  1. githubrobbi commented on Aug 24, 2026

    @githubrobbi
    Collaborator

    Root cause: upstream rustc/clippy regression β€” no code defect on our side

    The floating nightly this run used, 1.100.0-nightly (fb6531d55 2026-08-23), is the nightly that enabled the next-generation trait solver (rust-lang/rust#160895). Under the next solver, clippy's large_futures lint ICEs while computing layout_of on async-fn opaque types β€” upstream rust-lang/rust#161563 / rust-lang/rust#161495. That lint is in clippy::pedantic, which this workspace denies, and it runs layout on every async fn's future β€” hence the ICE storm across all three platforms, including inside tokio's own opaques. cargo check on the same nightly is unaffected; only the clippy leg ICEs.

    Fix status (all upstream, already done): rust-lang/rust-clippy#17601 (merged 2026-08-23 17:02 UTC) fixes the lint under the next solver; the Clippy subtree sync rust-lang/rust#161416 carrying it merged 2026-08-24 02:35 UTC β€” after the 08-24 nightly cutoff, so the first fixed toolchain is nightly-2026-08-25.

    Action for us:

    • No dependency bump applies (toolchain-side, unlike the ethnum episode) and no source change is needed.
    • Lint posture unchanged and non-negotiable: large_futures stays denied β€” no allow, no lint-set trimming to dodge an upstream ICE.
    • Pin-bump guidance per this canary's purpose: skip nightly-2026-08-23/24 β€” the next just toolchain-sync lands on β‰₯ nightly-2026-08-25. That bump also brings the next-gen trait solver onto the pinned gate; if the stricter solver surfaces new lint findings, they get real fixes, not exceptions.
    • Verification: workflow_dispatch the Nightly Canary once nightly-2026-08-25 is published (~2026-08-25 morning UTC); close this issue on green. Do not re-dispatch before then β€” the current latest nightly still lacks the fix and would file a duplicate tracker.
  2. github-actions commented on Aug 25, 2026

    @github-actions
    ContributorAuthor

    🐀 Nightly Canary failed on main

    Field Value
    Workflow 🐀 Nightly Canary
    Run #18
    Attempt 1
    Branch main
    Commit 910364a
    Triggered by @githubrobbi

    Filed by ci-failure-notify.yml after the 60-second auto-rerun-transient window: auto-rerun-transient saw no transient signature in the failed-job logs β†’ genuine failure on first attempt.

    ⚠️ This is an early-warning signal from the floating-nightly canary, not a broken pin. main still builds on the pinned toolchain. Investigate before the next pin bump; if it is an upstream/dep regression, the fix is usually a dependency bump (cf. the ethnum 1.5.2β†’1.5.3 episode), not a toolchain downgrade.

    πŸ“§ Notification sent to: cifail@uffs.io

  3. githubrobbi commented on Aug 25, 2026

    @githubrobbi
    Collaborator

    Closing as verified fixed: manual canary dispatch on nightly-2026-08-25 (first toolchain with the clippy large_futures next-solver fix, rust-lang/rust#161416) shows zero unexpected rigid alias in layout_of errors β€” the ICE this issue tracked is gone. The run is still red from a different, unrelated regression in the same nightly (clippy's new empty_enums lint false-positive on zerocopy FromBytes derive expansions), tracked separately with full analysis in #617 so each canary issue names exactly one root cause. Pin-bump guidance: skip nightly-2026-08-23/24 (the ICE) AND hold before β‰₯ 08-25 until the zerocopy false positive resolves β€” see the successor issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions