Repository navigation
Conversation
Member
|
I'm busy next week, but will plan to take a look at this in early November. Thanks for the fact that the PR includes a test, that's very helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting from an array of observations before computing apparent places currently drops the observer and crashes:
Keep the ephemeris, corresponding barycentric observer, Earth-relative observer vector and cached light time when indexing an ICRF position. Array observers are indexed with the observation; a scalar observer shared by a star catalogue remains scalar. Barycentric positions retain their self-reference.
This also restores observing from an indexed barycentric position, phase angles after selection, and Earth-occultation checks on selected apparent positions. Regression tests cover integer, slice, repeated/reordered and boolean selections, including a star catalogue with one observer.
The project's
test-code.shpasses with the pinned Python 3.8 dependencies, andtest-docs.shand Pyflakes pass. A separate Python 3.12/NumPy 2.5 run retains the existing upstream failures; the added indexing tests pass. Workloads using the shipped JPL ephemeris agree with separately evaluated scalar observations, and complete unselected outputs remain identical on both profiles.