Skip to content

Fix reversed astrometric velocities for stars - #1149

Open
vera-rubin wants to merge 1 commit into
skyfielders:masterfrom
vera-rubin:fix/star-velocity
Open

vera-rubin wants to merge 1 commit into
skyfielders:masterfrom
vera-rubin:fix/star-velocity

Conversation

@vera-rubin

Copy link
Copy Markdown

Observing a Star with positive proper motion returns a negative right ascension rate. We get about -2.73785 mas/day instead of +2.73785 mas/day below, contrary to the documented position derivative:

from skyfield.api import SSB, Star, load
from skyfield.framelib import ICRS

t = load.timescale().tdb_jd(2451545.0)
star = Star(ra_hours=0, dec_degrees=0,
            ra_mas_per_year=1000, parallax_mas=1000)
print(SSB.at(t).observe(star).frame_latlon_and_rates(ICRS)[4].mas.per_day)

We now subtract the observer’s velocity from the star’s velocity in all three scalar and array branches. The regression test fails before the change and passes after, and all 49 existing tests in the relevant modules still pass.

— ChipLab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant