Skip to content

Tests: allow last-ulp libm differences in test_velocity_in_ITRF_to_GCRS2 (arm64) #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RegularJoe-CEO wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tests: allow last-ulp libm differences in test_velocity_in_ITRF_to_GCRS2 (arm64) #1147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion skyfield/tests/test_positions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,12 @@ def test_velocity_in_ITRF_to_GCRS2():
relative_error = (length_of(actual_motion - predicted_motion)
/ length_of(actual_motion))

acceptable_error = 1.8e-11
# The motion over 1 second is only ~7.3e-5 of the unit vector, so
# a single-ulp (~1.1e-16) difference in sin/cos/atan from the
# platform's math library moves this ratio by ~1.5e-12. Measured:
# 1.735e-11 on x86_64 (glibc), 1.801e-11 on arm64 (macOS libm),
# same NumPy. Leave room for that last-ulp noise. See #582.
acceptable_error = 2.0e-11
assert relative_error < acceptable_error

def test_light_time_method():
Expand Down
Loading