Skip to content

Android: don't start the game thread twice when recreated during setup #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwidge merged 1 commit into from
Oct 3, 2026
Merged

Android: don't start the game thread twice when recreated during setup #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions sys/android/forkfront/src/com/tbd/forkfront/ForkFront.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public String decode(byte[] bytes) {
};

nhState = new NH_State(this, decoder);
new UpdateAssets(this, onAssetsReady).execute((Void[])null);
new UpdateAssets(this, assetsReadyFor(nhState)).execute((Void[])null);
}
else
{
Expand Down Expand Up @@ -195,20 +195,29 @@ public void onConfigurationChanged(Configuration newConfig)
}

// ____________________________________________________________________________________
private UpdateAssets.Listener onAssetsReady = new UpdateAssets.Listener()
// If the activity is recreated while the assets are being copied, the old copy finishes
// after a new NH_State has replaced this one. Only the copy started for the current state
// may start the game, or the game thread would be started twice.
private UpdateAssets.Listener assetsReadyFor(final NH_State state)
{
@Override
public void onAssetsReady(File path)
return new UpdateAssets.Listener()
{
// Create save directory if it doesn't exist
File nhSaveDir = new File(path, "save");
if(!nhSaveDir.exists())
nhSaveDir.mkdir();
@Override
public void onAssetsReady(File path)
{
if(state != nhState)
return;

PreferenceManager.setDefaultValues(ForkFront.this, R.xml.preferences, false);
nhState.startNetHack(path.getAbsolutePath());
}
};
// Create save directory if it doesn't exist
File nhSaveDir = new File(path, "save");
if(!nhSaveDir.exists())
nhSaveDir.mkdir();

PreferenceManager.setDefaultValues(ForkFront.this, R.xml.preferences, false);
state.startNetHack(path.getAbsolutePath());
}
};
}

// ____________________________________________________________________________________
@Override
Expand Down
Loading