Skip to content

feat(identity): preview emails and welcome users at signup - #631

Merged
harlan-zw merged 4 commits into
mainfrom
fix/welcome-onboarding-defaults
Oct 12, 2026
Merged

harlan-zw merged 4 commits into
mainfrom
fix/welcome-onboarding-defaults

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

New accounts should receive a welcome at signup and see the update emails before choosing them. Send the welcome once when GitHub creates an account with an email address. Returning sign-ins never resend it, and email failures do not block sign-in.

Signup sends one welcome, while onboarding saves recurring choices and opens read-only previews

Replace the onboarding welcome toggle with previews of the welcome, weekly, and digest templates. Use larger Nuxt UI checkboxes and a larger auth logo. New accounts start with recurring emails off; returning accounts keep their saved choices.

Show author commit subjects in public previews and sent digests, with links to each Skill file's GitHub history. Generated summaries never replace the commits. Weekly email rows wrap on phones instead of clipping long Skill names.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 12, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-12 14:52 UTC.

GitHub merged this pull request.

No material findings were recorded.

The pull request closed.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-zw

harlan-zw commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

🤖 Agent verification of head 713c3e9833a631d258c5b5557c655fe7a1aa68f5.

Checked the built site with a read-only local account fixture. The welcome checkbox is gone. Two recurring choices start unchecked, with 24px Nuxt UI controls. The auth logo measures 192px wide.

All three previews render the actual email templates. Public source reads produced seven named weekly Skills and five updated Skills. The digest shows author commit subjects and links to each Skill file’s GitHub history. Generated summaries do not replace commit subjects. No email was sent during this check.

Phone frames fit at 375px and 390px. Closing a preview restores focus and preserves email choices. An independent agent reviewed the screenshots.

Desktop onboarding Phone onboarding
Desktop onboarding with two recurring choices and three previews Phone onboarding with larger logo and checkboxes
Weekly preview Digest preview Welcome preview
Weekly preview with real trending Skills Skill updates preview with author commit subjects Founder welcome preview

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 12, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 12, 2026
@harlan-zw harlan-zw changed the title fix(identity): default onboarding to one welcome email feat(identity): preview emails and welcome users at signup Oct 12, 2026
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. label Oct 12, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 12, 2026
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. harlan-agent-ready The automated Review passed every gate on this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 12, 2026
@harlan-zw
harlan-zw merged commit 5792496 into main Oct 12, 2026
8 checks passed
@harlan-zw
harlan-zw deleted the fix/welcome-onboarding-defaults branch October 12, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant