UCRT - #382
Conversation
|
Huh. The build is failing in vim. I will investigate later. |
UCRT doesn't work on windows XP anyway, unless you static link it. Only MSVC is capable of this.
|
Vim 9.0 ships prebuilt Windows XPM libraries in its source tarball under src/xpm/, including: For some reason, vim has a binary lib committed somewhere. I don't know why... |
|
I'm so confused how this is giving errors in CI, when it builds fine on my machine. |
|
Somehow only half the patch was applying or something. @skeeto any ideas? |
|
Hmm, in CI the patch isn't piped into |
|
Ah, so you regenerated the patch to fix it. Patching is done outside a container, using the system's |
|
Yeah I was very confused. It was giving errors that 32 bit support wasn't compiled in gcc, when by all accounts it should be, and when I applied the patch with busybox-w32 on my machine it built totally fine. |
|
You are actually trying to push to master instead of a separate branch, although idk if its possible to make a PR into a branch that doesn't exist yet? In any case, the word of advice is to steer way clear of UCRT. In fact one of the big reasons to use minGW in the first place is that you can cleanly stay off UCRT without resorting to tricks compared to MSVC that tries its hardest to push it on you. |
|
Just because the PR is open doesn't mean I'm going to merge it. I definitely wouldn't merge this without also being able to offer an msvcrt variant. This is purely experimental. Ucrt is better in some ways, worse in others. Apparently it's required for sanitizers to work. |
|
I just want to keep it researched and know what is involved in case it becomes useful later. I have several PRs open that I don't intend to merge. |
|
Turns out, for gcc 14, Pali added an -mcrtdll option. So I would get that working so it can be selected, if I was going to merge this. No plans to do it soon. |
|
I appreciate these research branches, @Peter0x44. |
|
In your shared session which model was that and what effort? It's a little frustrating the shared view doesn't indicate it. |
|
Gpt 5.6 sol extra high |
For those who would prefer a w64devkit with ucrt instead of msvcrt, I'm throwing up this branch.