Repository navigation
Add a download limit for localhost on Linux - #116
Merged
Merged
Conversation
WebPageReplay tests run on loopback, where throttle could only add latency, so pages always downloaded at memory speed. That hides regressions that cost bandwidth, like a heavier HTML page or a larger image. The limit is for all traffic on loopback, because the browser and the server both send on it. Requests and ACKs are small, so it works as a download limit. A profile together with --localhost now uses the profile's download and RTT; before, it throttled the real network interface instead. Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebPageReplay tests run on loopback, where throttle could only add latency, so pages always downloaded at memory speed. That hides regressions that cost bandwidth, like a heavier HTML page or a larger image.
The limit is for all traffic on loopback, because the browser and the server both send on it. Requests and ACKs are small, so it works as a download limit. A profile together with --localhost now uses the profile's download and RTT; before, it throttled the real network interface instead.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com