fix: dispatch relative volume from protocol volume field - #67
Merged
Merged
Conversation
The server's updateDevice() stores an adjustVolume response's value.volume as
the device's absolute level, so echoing the delta back left device.volume set
to values like -20 and corrupted the volume reported to Alexa and Google.
onAdjustVolume can now return { success, volume } to report the level after the
adjustment. Returning a plain boolean keeps the previous delta echo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
adjustVolumeon both sides of the exchange. Verified against the SinricPro server source rather than inferred from the SDK alone.