22 bucket access for users other than admin - #23
Merged
Conversation
A role is instance-wide, so an operator who may write to one bucket may write to every bucket. Each account now also carries which buckets it may touch — write, read, or none — as one fallback plus exceptions, so "these buckets only" and "everything except this one" are the same mechanism. Grants narrow a role and never widen it: a readonly account granted write access to a bucket still only reads it. An administrator is never narrowed, because they could rewrite their own grants anyway and a lockout there is unrepairable. S3 keys are held to their owner's grants, read fresh per request. Requests naming no bucket — ListBuckets, the console's bucket and allocation lists — are filtered rather than refused. Bucket-scoped console routes use guardBucket(), which hands the handler the name so it cannot read one and forget to check it. The field is appended to the user record, so no format version moved and an account written before this reads back unrestricted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.