Repository navigation
Conversation
GTK 4.22 added get_default_attributes, get_extents, get_offset, set_caret_position and set_selection to GtkAccessibleText, and Vala 0.56 declares them abstract, so WriteDocView no longer builds against GTK 4.24. Report each as unsupported. Assisted-by: DeepSeek:deepseek-flash AI-Scope: implemented the five GtkAccessibleText vfuncs GTK 4.22 added, each reporting unsupported.
Author
|
@mirkobrombin for review when you have a moment. |
Author
|
@mirkobrombin this still applies cleanly to current main; ready for review when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTK 4.22 added five GtkAccessibleText vfuncs that Vala 0.56 declares abstract,
so WriteDocView no longer builds against GTK 4.24. Each now reports
unsupported. Verified: main fails to build on Debian forky; this builds.
AI assistance: disclosed