Skip to content

[OMEGA-450] Fix: Cli numeric config - #381

Open
timur-ashkenov wants to merge 3 commits into
singnet:mainfrom
timur-ashkenov:fix/cli-numeric-config
Open

timur-ashkenov wants to merge 3 commits into
singnet:mainfrom
timur-ashkenov:fix/cli-numeric-config

Conversation

@timur-ashkenov

Copy link
Copy Markdown
Collaborator

Description

Fixes #359.
Parse numeric CLI settings as numbers while keeping string settings unchanged. Reject numeric options without a value.

How Has This Been Tested?

Reproduced the issue on main: starting Omega with maxFeedback=25000 failed with an arithmetic error.
Repeated the same scenario with the fixes: Omega ran for three iterations successfully. Also checked YAML configuration and missing values.
95 Python tests and 42 MeTTa checks passed.

Checklist

  • PR contains autogenerated code
  • Self-review completed
  • Test scenarios above are passed with the version of the code from PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OMEGA-450] Command-line configuration values arrive as strings, so a numeric knob set there breaks arithmetic

2 participants