Skip to content

[OMEGA-449] Pass secrets to the build workflow's autotests - #371

Merged
TossSky merged 3 commits into
singnet:mainfrom
sassless:OMEGA-449-build-secrets-inherit
Oct 5, 2026
Merged

TossSky merged 3 commits into
singnet:mainfrom
sassless:OMEGA-449-build-secrets-inherit

Conversation

@TossSky

@TossSky TossSky commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Without secrets: inherit in build.yml, the refreshed token never reached the autotests on pushes to main, so the git push test was always skipped.

Checklist

  • PR contains autogenerated code
  • Self-review completed
  • Test scenarios above are passed with the version of the code from PR

@TossSky

TossSky commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

@sassless can you please review

@TossSky
TossSky requested a review from sassless September 29, 2026 15:32
@anseliv
anseliv requested a review from BANGLADESH228 October 1, 2026 11:11

@BANGLADESH228 BANGLADESH228 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we pass only the CICD_GITHUB_PAT here instead of using secrets: inherit?

secrets:
  CICD_GITHUB_PAT: ${{ secrets.CICD_GITHUB_PAT }}

This would keep the build workflow least-privileged while still providing the secret required by autotests. We can leave release.yml and manual.yml unchanged with their existing inherit pattern.

@BANGLADESH228 BANGLADESH228 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's fine.

@TossSky
TossSky merged commit 7c0e87a into singnet:main Oct 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants