Repository navigation
[OMEGA-449] Pass secrets to the build workflow's autotests - #371
Merged
Merged
Conversation
Collaborator
Author
|
@sassless can you please review |
BANGLADESH228
requested changes
Oct 1, 2026
BANGLADESH228
left a comment
There was a problem hiding this comment.
Could we pass only the CICD_GITHUB_PAT here instead of using secrets: inherit?
secrets:
CICD_GITHUB_PAT: ${{ secrets.CICD_GITHUB_PAT }}
This would keep the build workflow least-privileged while still providing the secret required by autotests. We can leave release.yml and manual.yml unchanged with their existing inherit pattern.
BANGLADESH228
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without
secrets: inheritinbuild.yml, the refreshed token never reached the autotests on pushes to main, so the git push test was always skipped.Checklist