Repository navigation
fix(trigger): keep each worker's egress gateway address out of the env sync - #9821
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Collaborator
Author
Contributor
 [Medium impact] The PR appears safe to merge, with the documented one-time worker configuration restore. SummaryStops the app's gateway addresses from overwriting worker-specific addresses during Trigger.dev env sync.
Reviews (2) · Last reviewed commit: "fix(trigger): keep each worker's egress ..." · Reviewed by Greptile |
…v sync The Trigger.dev env sync copies the app's OUTBOUND_GATEWAYS over the worker value. The app reaches a gateway through the VPC load balancer; workers reach it through their own private endpoint, so the copied URL is unreachable from a run and every gateway-routed request in a background run fails with GATEWAY_UNAVAILABLE after two connect timeouts. OUTBOUND_GATEWAYS is now Trigger-owned like REDIS_URL; the shared credentials and routing source still sync.
waleedlatif1
force-pushed
the
fix/trigger-owned-outbound-gateways
branch
from
November 9, 2026 23:34
f536187 to
e719c2d
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OUTBOUND_GATEWAYSwasn't on it, so each deploy overwrote the worker's gateway URL with the app's VPC load-balancer URL.GATEWAY_UNAVAILABLEafter two connect timeouts. App-side requests are unaffected.OUTBOUND_GATEWAYSis now Trigger-owned, likeREDIS_URL.OUTBOUND_GATEWAY_CREDENTIALSandOUTBOUND_ROUTING_SOURCEare identical for app and worker and keep syncing.Verification
UND_ERR_CONNECT_TIMEOUTon both CONNECT attempts.trigger-env.test.tsfails on the old key list and passes with the fix.Follow-up after merge
The worker value has to be restored once in each Trigger.dev environment that syncs (staging, prod). The sync now leaves it alone.