Repository navigation
improvement(search): refuse a live chunk index before the provider read - #9805
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryThis PR rejects a nonzero live
Reviews (2) · Last reviewed commit: "test(search): guard the search fixture r..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_documentrefuses a livestartChunkIndexother than 0 before resolving the account and fetching the document from its provider, instead of after; a client that guesses a chunk index now gets the "continue using next.startOffset" correction in about 2 s instead of 8–9 sstartChunkIndexdescription says to copynext.startChunkIndexfrom a prior read (live documents always use 0). It told clients to take a chunk index "from search", which search results stopped carrying in improvement(search): send each Search MCP result fact once #9778, and clients started guessing nonzero valuesType of Change
Testing
bunx vitest run lib/sim-search/live/application.test.ts lib/knowledge/mcp(137 passed), biome on changed filesChecklist
test-auditauthoring gate)