Skip to content

chore(execute): tidy credential-actor tests and comment - #9775

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/execute-actor-followup
Nov 7, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/execute-actor-followup

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to fix(execute): derive credential actor from auth type, not body isClientSession #9771. No behavior change
  • Credential-actor test now iterates EXECUTION_CALLERS with an expectation keyed by caseName instead of re-typing callers by index, and reads the snapshot object directly (the string-parse branch was dead)
  • The two read/write authorization tests become one table in their own execution access level describe
  • Shortened the useAuthenticatedUserAsActor TSDoc to the one non-obvious why
  • Deliberately did not remove sessionUserId: on HITL resume userId becomes the resumer while sessionUserId keeps the original session user for personal env resolution, and stored paused snapshots carry it

Type of Change

  • Other: test/comment cleanup

Testing

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 7, 2026 8:09pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This cleanup appears safe to merge.

Summary

This PR tidies execution tests and shortens an explanatory comment without changing runtime behavior.

  • Workflow execution tests group caller and access checks around their named cases.

No actionable issues found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "chore(execute): tidy credential-actor te..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 83914e7 into staging Nov 7, 2026
61 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/execute-actor-followup branch November 7, 2026 20:12

This branch was previously deployed

1 inactive deployment
Preview — 3dfaec5a Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant