Repository navigation
chore(execute): tidy credential-actor tests and comment - #9775
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This cleanup appears safe to merge. SummaryThis PR tidies execution tests and shortens an explanatory comment without changing runtime behavior.
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "chore(execute): tidy credential-actor te..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXECUTION_CALLERSwith an expectation keyed bycaseNameinstead of re-typing callers by index, and reads the snapshot object directly (the string-parse branch was dead)execution access leveldescribeuseAuthenticatedUserAsActorTSDoc to the one non-obvious whysessionUserId: on HITL resumeuserIdbecomes the resumer whilesessionUserIdkeeps the original session user for personal env resolution, and stored paused snapshots carry itType of Change
Testing
app/api/workflows/vitest: 11 files, 118 tests passcheck:test-patterns,check:comment-hygienelocally; full gates in CIChecklist
test-auditauthoring gate)🤖 Generated with Claude Code