Skip to content

improvement(ci): run WebKit acceptance in pinned browser containers - #9652

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-webkit-container
Nov 4, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-webkit-container

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Run Blacksmith mobile and docs WebKit acceptance through a matching, digest-pinned browser container. Keep the app, fixtures, native modules and harness on the host.
  • Preserve Chromium and GitHub fallback, all existing checks and report paths, and owned cleanup on failures and cancellation.

Type of Change

  • Improvement

Testing

Three paired runs preserved 1,164 check results (including 24 existing unavailable results) and 774 host screenshots. Docs jobs saved 68–71 seconds per pair; the parallel mobile group's slowest job improved in all three pairs. Individual shard timings vary. Cold and warm image pulls, native AMD64 identity, failure traces, endpoint rejection and ownership/cancellation cleanup were verified.

Full root test (727 fresh script cases, fresh app and CLI suites, all 20 workspace tasks); lint; 29 workspace type checks; all 62 audits; actionlint; ShellCheck; cleanup and test-audit review.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 4, 2026 1:27am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Blacksmith mobile and docs WebKit jobs now use a digest-pinned browser container. The app, fixtures, and test scripts stay on the host.

  • Blacksmith mobile and docs WebKit tests use a pinned browser container.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Acceptance job] --> B{Blacksmith WebKit?}
  B -->|Yes| C[Start pinned browser container]
  C --> D[Host test script connects over loopback]
  B -->|No| E[Install and launch native browser]
  D --> F[Host app and fixtures]
  E --> F
  D --> G[Host reports and screenshots]
  C --> H[Check ownership and stop container]
Loading

Reviews (1) · Last reviewed commit: "improvement(ci): run WebKit acceptance i..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit e1a45a0 into staging Nov 4, 2026
83 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-webkit-container branch November 4, 2026 01:28

This branch was successfully deployed

1 active deployment
Preview — cbc77453 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant