Repository navigation
feat(sim-links): create or copy a Sim link from search results and file shares - #9648
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issues remain. SummaryAdds Create Sim link and Copy Sim link actions to source menus and shared-file dialogs.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 16 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…ves, hide on failed lookups
waleedlatif1
force-pushed
the
feat/sim-link-from-result
branch
from
November 4, 2026 01:06
d042dd2 to
8af0197
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/organizations/[id]/sim-linkstakes an exacturlfilter through the existing list operation, so the lookup keeps the same authorization and unlisted visibility as browsingsim/<name>resolves for the session (resolveSimLinkOrganization, the resolver the redirect and extension suggestions use), resolved server-side in the organization and workspace layouts and provided bySimLinkOrganizationProvider; null hides them, so guests and orgs with Sim links off see nothing, and a failed lookup offers nothing rather than risk a duplicatesuggestSimLinkNameturns a title into a valid lower-case name;simLinkUrlbuilds the copyable address (the Links page now uses it too)Type of Change
Testing
scripts/test-sim-links-e2e.ts: new check that a destination lookup returns only links opening exactly that address, hides another member's unlisted link, and returns nothing for an unknown addresslib/sim-links/validation.test.ts: title to name (case, punctuation, hyphen collapse), cut to the length limit without a trailing hyphen, empty when nothing usable; reverting the lower-casing or the trailing-hyphen trim turns a case red/cleanupand/simplifypasses appliedChecklist
test-auditauthoring gate)