Repository navigation
improvement(search): cite public web results like connected sources in Search Assistant - #9647
Merged
Merged
Conversation
…n Search Assistant
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; both previous findings are fixed and no new blocking issue was found. SummarySearch Assistant can show cited public web pages alongside connected documents.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…test, mark chat open-world
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web_search/web_fetchwith acitationIdon each result)web_search/web_fetchjoinsearch_workspace/read_documentin oneisCitationToolset, andtoCitationResultmaps a page'surl/titleto the citation fields, so web pages render as the same source cards, sources panel, and activity result list as connected documents<source>tag still resolves only against a successful cited tool result; uncited web research (Build, main agent) stays out of source cards and is not persistedchatdescription no longer says "No web search"Type of Change
Testing
resolve-citations.test.ts: a web citation resolves from a successful cited result, live and after persistence; a failed result resolves nothingretrieval-citations.test.ts: cited web pages compact to bounded citations; uncited and failed web results compact to nothingtool-activity-group.test.tsx: cited web results list like search results; uncited web research shows no disclosureassistant-stream.test.ts: the "unrelated tool" case now usescall_integration_tool, sinceweb_searchis an intended evidence sourceChecklist
test-auditauthoring gate)