Repository navigation
improvement(executor): make run-from-block refusals actionable - #9636
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Low impact] The PR appears safe to merge, with no outstanding findings. SummaryThe PR gives refused block runs clearer messages and next steps.
Reviews (3) · Last reviewed commit: "chore(executor): type subflow configs in..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…en by workflow id
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
validateRunFromBlocknow returns a structuredrefusal(block_not_found,inside_subflow,upstream_not_executed), carried onRunFromBlockValidationError; class, error codes and message prefixes the canvas matches on are unchangedUpstream dependency not executed: Fetch,Cannot run from block inside loop: Each row. Run the loop or the whole workflow instead.)run_from_block/run_blockrewrite the refusal for the agent from the loaded workflow state:run_workflow_until_block(stopAfterBlockId) or an executionId that ran the upstream blockrun_workflowrun_blockstill runs one approved blockType of Change
Testing
executor/utils/run-from-block.test.ts,executor/execution/executor.test.ts,lib/workflows/application/run-workflow-from-copilot.test.ts(59 passing); the 6 new/changed assertions fail on the pre-fix codecheck:comment-hygiene; type-check and remaining audits left to CIChecklist
test-auditauthoring gate)