Repository navigation
improvement(agent-cli): skip non-text files in grep instead of marking the search incomplete - #9635
Merged
Merged
Conversation
…g the search incomplete
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] This PR appears safe to merge. SummaryAgent
No actionable issues found. Tests were inspected but not run. Reviews (1) · Last reviewed commit: "improvement(agent-cli): skip non-text fi..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grepfetched/files/{id}/textfor every listed file, so fonts, video, images, and archives each raised "could not read text" and turned an otherwise complete search into exit 1 "Search incomplete"workspaceFileTextFormat(the same gate the agent's text read applies) before fetching; non-text files are skipped unread and reported as oneSkipped N files with no searchable text …stderr line that does not fail the search--innaming a non-text file returns "No matches" plus the skip note, not "Unknown --in selector"Type of Change
Testing
universal-grep.test.ts(4) andproject-file-grep.test.ts(1), all red before the fix, green after; 50/50 pass across both filesbun run lint; type-check and audits left to CIChecklist
test-auditauthoring gate)