Skip to content

improvement(sim-links): pass queries through, trim pasted punctuation, and suggest links from the address bar - #9508

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/sim-links-qol
Oct 31, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
improvement/sim-links-qol

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • sim/<name>?query now carries the query to the destination (plain, variable, and default destinations), appended after the destination's own parameters with their stored encoding untouched; the sign-in redirect keeps it too
  • A name pasted out of a sentence (sim/onboarding).) drops the trailing prose punctuation before lookup. Those characters are either ignored when matching or not allowed in names, so no distinct link is shadowed; values are never trimmed
  • Extension: sim address-bar keyword (sim, Space) suggests matching links as you type, most opened first, and Enter opens what was typed through the resolver. Backed by GET /api/sim-links/suggestions, which reads the same organization sim/ resolves in (one shared resolveSimLinkOrganization), never suggests unlisted links, and returns nothing where Sim Links is off
  • Extension CSP connect-src now allows only the configured Sim origin, for that one request; README and docs updated

Type of Change

  • Improvement

Testing

  • lib/sim-links/destination.test.ts: query passthrough (encoding preserved, duplicate keys, fragments, # in a typed value) and typed-path parsing, red before the change
  • Extension type-check and dev build (manifest has the omnibox keyword and the narrowed CSP); lint, check:api-validation:strict, check:boundaries

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Oct 31, 2026 8:18am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both earlier findings are fixed and no new actionable issues were found.

Summary

Adds query passthrough, pasted-name cleanup, and address-bar suggestions for Sim Links.

  • Sim link visits carry typed query parameters to their destination.
  • Standalone Sim link names drop trailing sentence punctuation.
  • The Chrome extension suggests Sim links from the address bar.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Type a Sim link] --> B[Fetch matching listed links]
  B --> C[Cache link records]
  C --> D[Add current values and query to suggestions]
  D --> E[Choose a suggestion]
  A --> F[Press Enter]
  E --> G[Open Sim link resolver]
  F --> G
  G --> H[Resolve session organization]
  H --> I[Open destination with values and query]
Loading

Reviews (2) · Last reviewed commit: "fix(extension): keep typed values when a..." · Reviewed by Greptile

Comment thread apps/extension/src/omnibox.ts Resolved
Comment thread apps/extension/src/omnibox.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 17 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/extension/src/omnibox.ts Resolved
Comment thread apps/extension/src/omnibox.ts Resolved
Comment thread apps/extension/src/omnibox.ts Resolved
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 31, 2026 08:18
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 19 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit c2cb498 into staging Oct 31, 2026
65 of 66 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/sim-links-qol branch October 31, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant