fix(docs): render the FAQ JSON-LD as a native script tag, and forbid data-typed next/script by waleedlatif1 · Pull Request #8875 · simstudioai/sim

waleedlatif1 · 2026-10-10T02:02:53Z

Summary

Render the docs FAQ JSON-LD as a native <script type='application/ld+json'>. next/script (default afterInteractive) renders nothing on the server and injects from an effect, so the FAQPage structured data never reached the served HTML — same bug and same fix as 025ea4d / 5da48d0
Extend check:source-text (already in check:audits) to fail on any next/script element in apps/** whose static type isn't JavaScript, so this can't ship a fourth time. The message points at the native-script + serializeJsonLd pattern

Type of Change

Bug fix

Testing

bun run scripts/check-source-text.ts passes on this branch; with the pre-fix faq.tsx it fails at faq.tsx:94, and with the pre-025ea4d2bd structured-data.tsx it fails at its three JSON-LD sites
Audited the other next/script uses in apps/sim and apps/docs — all load external JS via src, none affected
Full audits, lint, type-check and docs build run in CI

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…data-typed next/script The FAQ component rendered its FAQPage JSON-LD through next/script with the default afterInteractive strategy, which returns null on the server and injects the tag from a client effect, so the served HTML never carried it. Render a native <script> the way #6763 fixed the other docs JSON-LD blocks; serializeJsonLd already escapes '<'. check:source-text now also fails on a next/script element in apps/** whose type is not JavaScript, naming the native-script fix.

vercel · 2026-10-10T02:02:56Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 10, 2026 2:24am UTC

cubic-dev-ai

All reported issues were addressed across 2 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-10T02:06:34Z

Confidence Score: 5/5

[Medium impact] No separate new issue was found that blocks merging.

Summary

The PR renders FAQ JSON-LD with a native <script> and adds a source audit for data-typed next/script elements.

The docs FAQ puts its JSON-LD in the HTML served to crawlers.
The source-text audit rejects data-typed next/script elements in app source.

_{Reviews (4) · Last reviewed commit: "fix(audits): keep JSX template literals ..." · Reviewed by Greptile}

… types, and scan MDX pages

waleedlatif1 · 2026-10-10T02:08:51Z

@greptile

waleedlatif1 · 2026-10-10T02:08:53Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T02:08:58Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 2 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…de examples

waleedlatif1 · 2026-10-10T02:14:53Z

@greptile

waleedlatif1 · 2026-10-10T02:14:54Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T02:14:59Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

…ne code

waleedlatif1 · 2026-10-10T02:20:21Z

@greptile

waleedlatif1 · 2026-10-10T02:20:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T02:20:28Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread scripts/check-source-text.ts Outdated

Comment thread scripts/check-source-text.ts Outdated

greptile-apps Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread scripts/check-source-text.ts Outdated

Comment thread scripts/check-source-text.ts Outdated

vercel Bot deployed to Preview October 10, 2026 02:07 View deployment

fix(audits): match only the real type prop, fail closed on expression…

3eb8131

… types, and scan MDX pages

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread scripts/check-source-text.ts Outdated

greptile-apps Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread scripts/check-source-text.ts

fix(audits): recognize default-as next/script imports and skip MDX co…

c4f55aa

…de examples

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread scripts/check-source-text.ts

fix(audits): keep JSX template literals intact when skipping MDX inli…

765cda1

…ne code

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

vercel Bot deployed to Preview October 10, 2026 02:24 View deployment

waleedlatif1 merged commit e526a91 into staging Oct 10, 2026
48 checks passed

waleedlatif1 deleted the fix/guardrails-docs branch October 10, 2026 03:44

Conversation

waleedlatif1 commented Oct 10, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

waleedlatif1 commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 10, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 10, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading