fix(knowledge): read the projection-filled probe off the partial index instead of a sequential scan - #8139
Merged
Conversation
…x instead of a sequential scan
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELECT EXISTS (SELECT 1 FROM <projection> WHERE acl IS NULL). PostgreSQL drops the order and limit inside anEXISTS, and while most rows are still unfilled the planner expects a sequential scan to meet one immediately, so it never picks the partialacl IS NULLindex. When the unfilled rows sit past the filled ones, that sequential scan walks the whole projection on every miss of the one-minute memoORDER BY id DESC LIMIT 1). That shape can only be served by the partial index, so the read is a handful of pages regardless of how many rows remain (the fill advances from the front of each range, so the last entry is also the one it reaches last)EXISTS, joined todocument) takes the same shapeType of Change
Testing
EXISTSformbun run lint,check:audits(47 audits),docs-manifest:check,type-checkpassChecklist