Skip to content

improvement(ui): use standard knowledge upload icon buttons - #8135

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-knowledge-upload-rowsfrom
codex/knowledge-upload-icons
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-knowledge-upload-rowsfrom
codex/knowledge-upload-icons

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use Button's existing icon size for knowledge upload Retry and Remove actions.
  • Keep ghost styling, glyph dimensions, accessible labels, callbacks and disabled/processing behavior.
  • Standardize the hit boxes from 16px to 20px, with shared corners and icon stroke. Ready/error rows grow by 2px; processing rows stay unchanged.

Validation

  • Workspace types and lint, all CI audits including import/API validation, registry and docs parity passed; EMCN tests passed.

  • Real KnowledgeUploadRow fixtures compare light/dark, rest, hover, disabled and processing states. Retry/remove callbacks are verified locally.

  • Final full-source scan removes all 4 targeted findings; actual-parent diff checker reports zero new findings. No linter changes or suppressions.

  • Before/after screenshots include labelled actual-component fixtures and documented end-to-end limitations.

  • Full build/test CI passed on b813a3aeccd3004c0360813e651b43ff3c2f6c09.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:38am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the shared icon-button variant is compatible with the existing row layout and preserves the controls’ behavior and accessibility.

Summary

This PR standardizes the Retry and Remove controls in knowledge-upload rows by replacing custom 16px sizing with the shared Button icon-size variant.

  • Uses the component library’s standard 20px icon-button geometry, corners, stroke, and ghost-icon styling.
  • Preserves accessible labels, callbacks, disabled behavior, button type, and explicit glyph dimensions.

Reviews (1) · Last reviewed commit: "improvement(ui): use standard knowledge ..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual review

Actual parent 70175ba788877e0320e48eff67bb4221614e5ca0 → implementation b813a3aeccd3004c0360813e651b43ff3c2f6c09. Each tile contains Before and After at matching viewport, theme, data and scale. Click the image for full resolution; a labelled 2× enlarged crop is included.

Coverage: Retry/removal in ready/error rows, uploading/processing states and disabled controls; light/dark and hover.

Intentional differences: Hit areas grow from 16px to 20px, corners become 4px and SVG stroke becomes 1.25px. Existing 12/14px glyph sizes are retained. Ready/error rows grow from 36px to 38px; processing rows are unchanged. Ghost icon ink uses the standard icon-button treatment.

Fixture limits: These fixtures render the actual KnowledgeUploadRow with local callback counters. Retry/remove and processing/disabled behavior were exercised; no real failed upload or storage retry was performed. Product CSS/fonts are used; hover is a fixture-only preview of the generated hover CSS.

The full scanner removes 4 targeted findings; the parent-relative diff checker reports zero new findings. Workspace type checks, lint, import/API audits and all EMCN tests passed. Full CI run.

comparison-all

@waleedlatif1
waleedlatif1 merged commit fc12400 into codex/control-fix-knowledge-upload-rows Sep 22, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/knowledge-upload-icons branch September 22, 2026 17:53

This branch was previously deployed

1 inactive deployment
Preview b813a3ae Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants