improvement(ui): use standard knowledge upload icon buttons - #8135
waleedlatif1 merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Before / after visual reviewActual parent Coverage: Retry/removal in ready/error rows, uploading/processing states and disabled controls; light/dark and hover. Intentional differences: Hit areas grow from 16px to 20px, corners become 4px and SVG stroke becomes 1.25px. Existing 12/14px glyph sizes are retained. Ready/error rows grow from 36px to 38px; processing rows are unchanged. Ghost icon ink uses the standard icon-button treatment. Fixture limits: These fixtures render the actual KnowledgeUploadRow with local callback counters. Retry/remove and processing/disabled behavior were exercised; no real failed upload or storage retry was performed. Product CSS/fonts are used; hover is a fixture-only preview of the generated hover CSS. The full scanner removes 4 targeted findings; the parent-relative diff checker reports zero new findings. Workspace type checks, lint, import/API audits and all EMCN tests passed. Full CI run.
|
fc12400
into
codex/control-fix-knowledge-upload-rows

Summary
Validation
Workspace types and lint, all CI audits including import/API validation, registry and docs parity passed; EMCN tests passed.
Real KnowledgeUploadRow fixtures compare light/dark, rest, hover, disabled and processing states. Retry/remove callbacks are verified locally.
Final full-source scan removes all 4 targeted findings; actual-parent diff checker reports zero new findings. No linter changes or suppressions.
Before/after screenshots include labelled actual-component fixtures and documented end-to-end limitations.
Full build/test CI passed on
b813a3aeccd3004c0360813e651b43ff3c2f6c09.