Skip to content

improvement(ui): use shared chips for ordinary actions - #8134

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-search-replace-fieldsfrom
codex/ordinary-action-overrides
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-search-replace-fieldsfrom
codex/ordinary-action-overrides

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use existing Chips for Open Sim, execution-detail Refresh, Replace and Replace All.
  • Use canonical 30px height, corners and typography. Keep Open Sim centered/full-width and Replace All visually emphasized without toggle semantics.
  • Preserve callbacks, labels, tooltips and disabled/loading conditions; use explicit button types.

Validation

  • Workspace types, lint, all CI audits including import/API validation, registry and docs parity passed.

  • EMCN and existing resume-page tests passed.

  • Matched light/dark component comparisons cover rest, hover, disabled/loading and 390px layouts. Local callbacks verified navigation, refresh and both replacement actions.

  • Final full-source scan removes all 8 targeted findings; actual-parent diff checker reports zero new findings. No linter changes or suppressions.

  • Before/after screenshots include labelled actual-component fixtures and documented end-to-end limitations.

  • Full build/test CI passed on 351b83b3bf1aff1b805dda6350a5f5f2f8414a9a.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:30am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the component substitutions preserve native button behavior and existing interaction guards.

Summary

This PR standardizes four ordinary UI actions on the shared EMCN Chip component while preserving their existing behavior.

  • Replaces the chat error-state Open Sim button with a centered, full-width Chip.
  • Replaces the execution-detail Refresh button with an outlined Chip and spinning refresh adornment.
  • Replaces the workflow search-and-replace actions with outlined and visually emphasized Chips.
  • Preserves native button types, callbacks, labels, tooltips, and disabled/loading conditions.

Reviews (1) · Last reviewed commit: "improvement(ui): use shared chips for or..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual review

Actual parent 39573f375f13883d611bc83828cab63f05e4dd6d → implementation 351b83b3bf1aff1b805dda6350a5f5f2f8414a9a. Each tile contains Before and After at matching viewport, theme, data and scale. Click the image for full resolution; a labelled 2× enlarged crop is included.

Coverage: Open Sim, Refresh, Replace and Replace All; light/dark, rest, hover, disabled/loading and 390px replacement-label fit.

Intentional differences: Canonical 30px chip height, corners and typography. The 32px actions become slightly shorter; refresh/replacement labels grow slightly. Open Sim stays centered and full width; Replace All retains emphasis without toggle semantics.

Fixture limits: The fixtures render actual ChatErrorState and ReplacementControls components. Refresh renders the exact changed header JSX extracted from the parent/final resume-page source, using local callbacks. Live execution-resume and chat-navigation workflows were not exercised. Product CSS/fonts are used; hover is a fixture-only preview of the generated hover CSS.

The full scanner removes 8 targeted findings; the parent-relative diff checker reports zero new findings. Workspace type checks, lint, import/API audits and all EMCN tests passed. Full CI run.

comparison-all

@waleedlatif1
waleedlatif1 merged commit 27d0467 into codex/control-fix-search-replace-fields Sep 22, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ordinary-action-overrides branch September 22, 2026 17:54

This branch was previously deployed

1 inactive deployment
Preview 351b83b3 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants