Skip to content

improvement(ui): use outline chips for auth actions - #8133

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-account-status-headingsfrom
codex/auth-outline-actions
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-account-status-headingsfrom
codex/auth-outline-actions

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use existing outline Chip/ChipLink styling for auth navigation, social/SSO sign-in, secondary invitation actions and individual unsubscribe actions.
  • Preserve auth heights, widths, labels, disabled/loading states and callbacks. Resting borders stay equivalent; hover uses the shared outline border instead of the default fill. Primary SSO styling is unchanged.

Validation

  • Workspace types and lint, all CI audits including import/API validation, registry and docs parity passed.

  • 349 EMCN tests and 5 invitation/unsubscribe consumer tests passed.

  • Before/after component comparisons cover light/dark, hover, loading/disabled and narrow auth layouts. Controlled local callbacks stand in for live OAuth and account requests.

  • Final full-source scan removes all 27 targeted findings; actual-parent diff checker reports zero new findings. No linter changes or suppressions.

  • Before/after screenshots include labelled actual-component fixtures and documented end-to-end limitations.

  • Full build/test CI passed on 280e0962f7dcccc9516c9b1fec0c6b1c89fe5d06.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:18am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the changes are limited to adopting the shared outline presentation and preserve the affected controls' behavior.

Summary

This PR consistently adopts the shared outline Chip styling for secondary authentication, invitation, and unsubscribe actions while preserving their existing behavior.

  • Replaces manually composed borders with variant='outline'.
  • Passes the SSO variant directly to the shared Chip component.
  • Removes imports that became unnecessary after eliminating manual class composition.
  • Retains existing dimensions, labels, callbacks, loading states, and disabled conditions.

Reviews (1) · Last reviewed commit: "improvement(ui): use outline chips for a..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual review

Actual parent 8674a0e3de769ab858e08370af2c5936606fef0b → implementation 280e0962f7dcccc9516c9b1fec0c6b1c89fe5d06. Each tile contains its own Before and After; click the image for full resolution.

The comparisons cover navigation, all three social providers, outline/primary SSO, secondary invitation actions and the three individual unsubscribe actions, in light/dark themes. Resting, hover, disabled/loading, 390px auth layouts and a 2× enlarged crop are included.

Intentional difference: outline hover uses the shared border treatment instead of adding the default chip fill. Existing auth heights, widths and alignment are retained; primary SSO stays unchanged.

These are labelled fixtures rendering the actual product components and product CSS/font. Hover is a preview of the generated hover CSS; OAuth/account requests and navigation use controlled local callbacks. Live OAuth and account-email workflows were not exercised.

Full scanner: 27 targeted findings removed, zero new parent-relative findings. Workspace type checks, lint, import/API audits, EMCN and consumer tests passed. Full CI run passed.

comparison-all

@waleedlatif1
waleedlatif1 merged commit b9e28cb into codex/control-fix-account-status-headings Sep 22, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/auth-outline-actions branch September 22, 2026 17:56

This branch was previously deployed

1 inactive deployment
Preview 280e0962 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants