Skip to content

refactor(ui): share account headings and auth control sizing - #8074

Open
BillLeoutsakosvl346 wants to merge 3 commits into
codex/control-fix-public-auth-headingsfrom
codex/control-fix-account-status-headings
Open

BillLeoutsakosvl346 wants to merge 3 commits into
codex/control-fix-public-auth-headingsfrom
codex/control-fix-account-status-headings

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Use shared public/account headings and EMCN control sizing across authentication and public forms.

  • Reuse heading and status compositions for invitation/account outcomes while preserving content, actions and state handling.
  • Auth submit, social-login, SSO, invitation, consent, unsubscribe and public-file controls use existing lg/center props instead of local height/centering constants. AuthInput, PasswordInput and credential fields share the 36px height.
  • Intentional visual changes: public chat/file fields previously fixed at 34px now use 36px; the SSO link uses the standard outlined 36px ChipLink; shared hover/neutral treatments and centering replace local approximations. These are standardization changes, not pixel-identical sizing.

Validation: all workspace type/import/API/lint checks, the complete EMCN suite and relevant consumer tests pass. Current-head full CI includes the application build and PostgreSQL integration tests. Actual components in browser fixtures cover light/dark, errors, disabled state, focus, narrow 390px forms and enlarged text. No live auth-provider requests or backend account changes were exercised. The existing URL, submission and validation logic is preserved.

Linters, screenshots, fixtures and reports are outside the product diff. Before/after screenshot comparisons document the intentional sizing changes.

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 9:42pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding findings or new actionable issues.

Summary

Consolidates invitation and email-preference headings and replaces local auth-control styling with shared EMCN sizing, alignment, and outline variants.

  • Uses shared 36px controls across authentication, public forms, and credential fields.
  • Replaces the SSO email-navigation button/link nesting with ChipLink and updates its test mock.
  • Preserves existing submission, validation, navigation, and loading logic.
  • No changes exist since the previous review. No new findings or additional repository-rule violations were identified.

Reviews (8) · Last reviewed commit: "improvement(ui): use shared sizing for a..."

Comment thread apps/sim/app/unsubscribe/unsubscribe.tsx Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread apps/sim/app/invite/components/invite-heading.tsx Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Invitation and email-preference screens share their status heading/subcopy layout. Email Preferences is the representative example.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 8674a0e3de.

Before and after: light heading

Additional theme/state comparisons

Before and after: dark heading

@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from staging to codex/typography-consolidation September 22, 2026 08:18
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Base automatically changed from codex/typography-consolidation to codex/control-fix-public-auth-headings September 22, 2026 17:57
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-public-auth-headings branch from 4d8c337 to f8bafb5 Compare September 22, 2026 20:04
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-account-status-headings branch from b9e28cb to d2f04f1 Compare September 22, 2026 20:33
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/app/(auth)/components/social-login-buttons.tsx
Comment thread apps/sim/app/(auth)/components/social-login-buttons.tsx
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 20 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/app/(interfaces)/chat/components/auth/email/email-auth.tsx
@BillLeoutsakosvl346 BillLeoutsakosvl346 changed the title improvement(ui): share account status headings refactor(ui): share account headings and auth control sizing Sep 22, 2026
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 20 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview 5d7f0029 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants