Skip to content

improvement(ui): share public headings and product typography - #8069

Open
BillLeoutsakosvl346 wants to merge 2 commits into
codex/emcn-consolidationfrom
codex/control-fix-public-auth-headings
Open

BillLeoutsakosvl346 wants to merge 2 commits into
codex/emcn-consolidationfrom
codex/control-fix-public-auth-headings

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Share the identical 40px heading and subtitle treatment across public chat, file-share and SSO access gates, preserving their content and behavior.
  • Centralize typography tokens and replace repeated product font-size/weight declarations with the shared scale. Keep imported rem units and leading where they already match.
  • Include the matching workflow-card heading change in the landing page's platform demonstration; other marketing presentation stays unchanged.

Intentional visual differences

This final diff includes typography normalization as well as the public-heading extraction. It is not entirely pixel-identical: workflow and note headings (including the platform demonstration) use 16px instead of 17px; small file-extension/avatar labels use 10px instead of 9px; the upgrade heading uses 28px instead of 30px; and the mobile workspace greeting uses 24px instead of 26px, retaining 28px on desktop. These use existing nearby scale values instead of adding near-duplicate tokens.

Validation

All workspace type checks, lint, import/API audits, generators and the complete EMCN suite pass against the actual target. Existing typography-merging tests cover the shared utility names. The previously captured public-access heading fixtures match in light/dark; that exact-match statement applies to the heading extraction, not the intentionally normalized sizes above. Authenticated flows and every typography consumer were not rechecked in the browser during the stack refresh. Audit tooling and review artifacts are outside the PR.

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 8:06pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no new actionable issue was introduced after the previous review, and the only prior finding was manually resolved with an explanation of the authorized design-system scope.

Summary

The PR introduces a shared public authentication header across chat, file-share, and SSO access gates while preserving their existing copy and presentation. It also centralizes the supporting typography scale and replaces equivalent arbitrary font sizes and weights with named design tokens throughout the application.

  • Adds PublicAuthHeader as the common heading and subtitle treatment for public access gates.
  • Reuses the component across chat authentication, public file authentication, and SSO forms.
  • Defines the expanded typography and weight scale centrally and updates consumers to use named tokens.
  • Keeps authentication behavior, validation, and dynamic verification content unchanged.
  • The prior global-style concern was manually resolved after the author clarified that these definitions are authorized design-system tokens.

Reviews (4) · Last reviewed commit: "improvement(ui): share public authentica..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Public password/auth screens share PublicAuthHeader, preserving the existing heading and subcopy styles.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 37fe35014c.

Before and after: 8069

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from codex/emcn-consolidation to codex/overrides-chip-sizing September 22, 2026 20:04
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-public-auth-headings branch from 4d8c337 to f8bafb5 Compare September 22, 2026 20:04
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/app/_styles/globals.css
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile Please re-review the current head. The inline response explains the shared definition and the authorized design-system scope.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 60 files

Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread apps/sim/app/(interfaces)/chat/components/input/input.tsx
Comment thread apps/sim/app/workspace/[workspaceId]/upgrade/upgrade.tsx
Comment thread packages/workflow-renderer/src/note/note-block-view.tsx
Comment thread apps/sim/app/workspace/[workspaceId]/home/home.tsx
@BillLeoutsakosvl346 BillLeoutsakosvl346 changed the title improvement(ui): share public authentication headings improvement(ui): share public headings and product typography Sep 22, 2026
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR. The description now covers the complete typography normalization and explicitly records its intended size changes; inline responses distinguish those from the unchanged public-heading extraction.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR. The description now covers the complete typography normalization and explicitly records its intended size changes; inline responses distinguish those from the unchanged public-heading extraction.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 60 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Base automatically changed from codex/overrides-chip-sizing to codex/emcn-consolidation September 23, 2026 02:11

This branch was successfully deployed

1 active deployment
Preview f8bafb50 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant