fix(mcp): let the read tool carry a request body - #8054
Merged
Merged
Conversation
call_read_operation declared no body, so the six read operations that post their filter as JSON — searchKnowledge, queryRows, queryRowsCount, searchTableRows, getSelector, and listSelector — could not be called at all. The dispatcher already sends a body for any non-GET operation that declares one and refuses a body for operations that do not, so both call tools now share one input schema.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call_read_operationdeclared nobody, so the six read operations that post their filter as JSON could not be called over MCP at all:searchKnowledge,queryRows,queryRowsCount,searchTableRows,getSelector, andlistSelectorresolveOperation, not by the schemaType of Change
Testing
Found by calling the deployed MCP server:
describe_operationreturns a body schema for these operations while the read tool offers nowhere to put it. Verified the fix end to end against a live server, and audited the whole catalog for the same class of gap — no GET declares a body, and every catalogued operation returns JSON, so these six were the only ones affected.Regression test added to the existing
tools/listtest, which drives the real JSON-RPC route. Confirmed it fails without the fix (expected … to have property "body") and passes with it. Full MCP suite: 55 tests across 4 files. Lint and type-check clean.Checklist