Skip to content

improvement(ui): share table sidebar headers - #8048

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-field-disclosuresfrom
codex/control-fix-table-sidebar-headers
Sep 20, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-field-disclosuresfrom
codex/control-fix-table-sidebar-headers

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Share the header layout and action buttons across column, enrichment and workflow configuration sidebars.
  • Preserve all five headers' title markup, overflow, spacing, icons and callbacks. Reuse EMCN Button without adding a new variant; add the existing keyboard-only focus treatment.

Type of Change

  • Improvement

Testing

  • All workspace type checks, lint, import/API validation and required repository audits pass; 21 existing consumer tests pass.
  • Source comparison accounts for five headers and seven actions and confirms the remaining caller logic is unchanged.
  • Browser fixture checked in light/dark themes, including long titles, close/back callbacks and keyboard activation.
  • Committed design check completed with four retained warnings in the shared action: the existing 28px geometry and three keyboard-focus styling declarations. These are deliberate product-level composition choices; changing geometry or adding a global variant would broaden this extraction. No checker rules were changed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 20, 2026 12:34am UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the extraction preserves the existing header structure and action behavior.

Summary

This PR consolidates five table-sidebar headers and seven close/back actions into shared components while preserving each consumer’s title, overflow, layout, and callback behavior.

  • Adds TableSidebarHeader as the canonical container for table configuration sidebar headers.
  • Adds TableSidebarHeaderAction around the existing EMCN Button configuration with a keyboard-visible focus treatment.
  • Migrates column, enrichment, and workflow sidebar headers without changing their underlying configuration logic.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  H[TableSidebarHeader] --> C[Column configuration]
  H --> EL[Enrichment list]
  H --> EC[Enrichment configuration]
  H --> W[Workflow configuration]
  A[TableSidebarHeaderAction] --> Close[Close actions]
  A --> Back[Back actions]
Loading

Reviews (1) · Last reviewed commit: "improvement(ui): share table sidebar hea..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 9566171 into codex/control-fix-field-disclosures Sep 20, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-table-sidebar-headers branch September 20, 2026 00:55

This branch was previously deployed

1 inactive deployment
Preview ebd1f101 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants