Skip to content

improvement(ui): share field mode toggles - #8046

Merged
waleedlatif1 merged 2 commits into
codex/control-fix-parameter-cardsfrom
codex/control-fix-field-mode-toggles
Sep 20, 2026
Merged

waleedlatif1 merged 2 commits into
codex/control-fix-parameter-cardsfrom
codex/control-fix-field-mode-toggles

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Share four editor field-mode buttons through one controlled product component. Preserve labels, state updates, read-only guards, tooltips and the existing 12px appearance.
  • Add the existing keyboard-only focus treatment and the standard icon colour transition to the shared control.

Type of Change

  • Improvement

Testing

  • All workspace type checks, lint, import/API validation and required repository audits pass.
  • 89 existing consumer tests pass. Source comparison confirms all four callers preserve labels, mode conditions, disabled guards and callbacks.
  • Reviewed a local before/after browser fixture. Committed design check completed with zero findings; dynamic inputs retain the checker's documented limitations.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 20, 2026 12:38am UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the shared component preserves the existing caller contracts and the previous transition requirement is now satisfied.

Summary

This PR consolidates four workflow-editor field-mode buttons into a controlled FieldModeToggle component while preserving labels, callbacks, active states, disabled/read-only guards, tooltips, and the existing 12px appearance. The follow-up adds the required color transition to the icon that owns the changing foreground color.

  • Reuses one accessible toggle implementation across canonical fields, tool permission mode, input-format mode, and manual boolean mode.
  • Adds keyboard-only focus styling to the shared control.
  • Preserves caller-owned state and mutation behavior.
  • Satisfies the previously reported interactive color-transition requirement.

Reviews (3) · Last reviewed commit: "fix(ui): transition field mode icon colo..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit c1c0a5e into codex/control-fix-parameter-cards Sep 20, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-field-mode-toggles branch September 20, 2026 00:55

This branch was previously deployed

1 inactive deployment
Preview b6096e1a Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants