Skip to content

fix(settings): align credential groups with organization rollout - #8043

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/credential-groups-settings-rollout
Sep 20, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/credential-groups-settings-rollout

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Apply the shared organization settings visibility rule before the Credential Groups availability check.
  • Keep Credential Groups in workspace settings when the organization rollout is off, and in organization settings when it is on.

Type of Change

  • Bug fix

Testing

  • 110 workspace and organization sidebar, routing, navigation, and authorization tests passed.
  • App type-check, repository lint, all 47 audits (including API boundary validation), block registry checks, and docs manifest check passed.
  • All eight cleanup review passes found no issues.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 20, 2026 12:03am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because Credential Groups remains available on the appropriate settings surface under the same feature and authorization conditions.

Summary

This PR corrects Credential Groups placement by applying the shared organization-plane rollout filter before workspace-specific availability checks.

  • Keeps Credential Groups in workspace settings while organization rollout is disabled.
  • Moves Credential Groups to organization settings while rollout is enabled.
  • Updates workspace sidebar expectations for administrators and members.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Credential Groups navigation item] --> B{Organization rollout enabled?}
  B -- No --> C{Viewer is organization admin and feature is available?}
  C -- Yes --> D[Show in workspace settings]
  C -- No --> E[Hide item]
  B -- Yes --> F[Hide from workspace settings]
  F --> G[Expose through organization settings with equivalent authorization]
Loading

Reviews (1) · Last reviewed commit: "fix(settings): align credential groups w..."

@waleedlatif1
waleedlatif1 merged commit ed282d6 into staging Sep 20, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/credential-groups-settings-rollout branch September 20, 2026 00:06

This branch was previously deployed

1 inactive deployment
Preview 39fa0b65 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant