Skip to content

improvement(ui): centralize tab strip action geometry - #8037

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-tab-strip-actions
Sep 20, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-tab-strip-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Add TabStripAction beside TabStrip to own its existing band-sized icon action geometry, using the existing Button variants.
  • Migrate 10 resource-panel actions, the built-in new-tab action, and the two matching platform-demo actions. Remove the old resource-button class helper; preserve labels, handlers, tooltips, icons, and the 26px resource-header override.

Type of Change

  • UI refactor

Testing

  • All workspace type checks, lint, required audits, registry check, and docs generation/checks passed.
  • EMCN: 346 tests passed. Relevant resource consumer suites: 6 tests passed. Extended the existing tab-strip suite for slotted event forwarding, refs, focus, and disabled behavior.
  • Browser fixture using real components: before/after computed geometry, typography, colors, radius, opacity, and icon stroke matched across 16 light/dark, 26px/30px, variant, and enabled/disabled cases. Checked mouse/keyboard activation and the new-tab limit.
  • Source comparison confirms all 12 migrated consumer controls preserve their other props and surrounding logic. Repository search found no stale helper references.
  • External conformance scan: 20 targeted findings removed, zero added. Committed design check completed with zero usage violations and 10 intentional central-definition notifications: the existing geometry and attached-tab margin moved into the companion. Known unchecked inputs remain outside the checker's coverage. Audit scripts and browser fixtures are outside this PR.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 19, 2026 9:24pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable correctness, security, or repository-rule violations were identified.

Summary

This PR centralizes tab-strip icon-action geometry in a reusable TabStripAction component while preserving existing control behavior.

  • Adds and exports TabStripAction as a ref-forwarding Button wrapper.
  • Migrates resource-panel, platform-demo, and built-in new-tab actions to the shared component.
  • Removes the redundant resource-specific geometry helper.
  • Extends DOM coverage for slotted events, refs, focus, native props, and disabled behavior.

Reviews (1) · Last reviewed commit: "improvement(ui): centralize tab strip ac..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 526e385 into staging Sep 20, 2026
37 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-tab-strip-actions branch September 20, 2026 00:56

This branch was successfully deployed

1 active deployment
Preview f180a1b0 Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants