Skip to content

improvement(ui): reuse chip inputs for remaining settings fields - #8030

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/control-fix-remaining-chip-fields
Sep 20, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/control-fix-remaining-chip-fields

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use ChipInput for the API-key and branding color fields, retaining the reveal control, color swatch, validation, and existing layout.
  • Add a leading-content slot to ChipInput and remove the unused local field-style helpers.

Type of Change

  • Refactor

Testing

  • Workspace type checks, lint, import/API audits, and documentation checks pass.
  • 346 EMCN tests and 4 relevant consumer tests pass.
  • Browser comparison of original and updated field markup in light/dark themes covers valid/invalid colors and hidden/revealed dummy API keys. Fixtures use application CSS; no live credentials were saved.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 19, 2026 8:58pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable behavioral, security, build, or repository-rule issues identified.

Summary

This PR consolidates the remaining API-key and branding-color fields onto the shared ChipInput component.

  • Adds a custom leading-content slot while preserving the existing icon fallback and trailing-adornment API.
  • Migrates the BYOK secret field without changing masking, reveal, autocomplete, or edit behavior.
  • Migrates branding color fields while retaining swatches, normalization, validation, and monospaced input text.
  • Removes the obsolete local chip-field styling helpers and their barrel exports.
  • Adds focused coverage for input identity and focus retention when leading content changes.

Reviews (1) · Last reviewed commit: "improvement(ui): reuse chip inputs for r..."

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
@waleedlatif1
waleedlatif1 merged commit 8b5109f into staging Sep 20, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-remaining-chip-fields branch September 20, 2026 00:58

This branch was previously deployed

1 inactive deployment
Preview bc8ddea3 Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants