refactor(ui): share log and enrichment details panels - #8026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@greptileai @cubic-dev-ai Please review the latest commit, including the closed-panel keyboard-focus fix. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
|
@greptileai @cubic-dev-ai Please review the latest commit, including the local CSS-variable sizing and retained inert behavior. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
|
@greptileai @cubic-dev-ai Please review the latest commit. The resize calculation now includes explicit whitespace; compiled CSS and browser geometry comparisons are unchanged. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai Please run a full review of this PR against its base branch on the current head, rather than an incremental review of only the latest commit. The latest incremental review reported no issues; this is the final review of the complete change. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Log details and table enrichment details duplicated the same sliding sidebar and external resize handle. Both now use EMCN
DetailsPanel, preserving their existing border, fill, shadow, responsive width, transition and mounted content when closed. Closed content is inert, so off-screen controls cannot receive keyboard focus; reopening restores access without losing state. Each screen still owns its content, keyboard commands, resize hook and persisted width.Validation: all 26 workspace type checks and lint checks, import-specifier resolution, API validation, 346 EMCN tests, and 11 relevant consumer tests passed. A source comparison confirms all 13 control/content subtrees are unchanged. Isolated browser comparisons in light/dark match at two widths and through close/reopen; live log and enrichment flows were not exercised. The external conformance scan adds no findings and removes the two migrated sidebar shadow findings.