Skip to content

refactor(ui): share log and enrichment details panels - #8026

Merged
waleedlatif1 merged 4 commits into
stagingfrom
codex/control-fix-details-panels
Sep 20, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
codex/control-fix-details-panels

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Log details and table enrichment details duplicated the same sliding sidebar and external resize handle. Both now use EMCN DetailsPanel, preserving their existing border, fill, shadow, responsive width, transition and mounted content when closed. Closed content is inert, so off-screen controls cannot receive keyboard focus; reopening restores access without losing state. Each screen still owns its content, keyboard commands, resize hook and persisted width.

Validation: all 26 workspace type checks and lint checks, import-specifier resolution, API validation, 346 EMCN tests, and 11 relevant consumer tests passed. A source comparison confirms all 13 control/content subtrees are unchanged. Isolated browser comparisons in light/dark match at two widths and through close/reopen; live log and enrichment flows were not exercised. The external conformance scan adds no findings and removes the two migrated sidebar shadow findings.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 19, 2026 8:06pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding findings or new issues in the latest change.

Summary

This PR consolidates the duplicated log and enrichment sidebars into a shared EMCN DetailsPanel.

  • Preserves caller-owned content, resize behavior, responsive width, styling, and transitions.
  • Keeps closed panel content mounted while making it inert.
  • Exports the shared component and adds focused coverage for resizing, width handling, refs, and retained state.
  • The latest commit makes the resize calculation’s whitespace explicit without changing its behavior.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  L[LogDetails] -->|content, width, resize handler| P[DetailsPanel]
  E[EnrichmentDetails] -->|content, width, resize handler| P
  P --> S[Sliding sidebar]
  P --> H[External resize handle]
  P --> I[Mounted inert content when closed]
Loading

Reviews (4) · Last reviewed commit: "style(ui): make resize calculation spaci..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/emcn/src/components/details-panel/details-panel.tsx
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai @cubic-dev-ai Please review the latest commit, including the closed-panel keyboard-focus fix.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@greptileai @cubic-dev-ai Please review the latest commit, including the closed-panel keyboard-focus fix.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread packages/emcn/src/components/details-panel/details-panel.tsx Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai @cubic-dev-ai Please review the latest commit, including the local CSS-variable sizing and retained inert behavior.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@greptileai @cubic-dev-ai Please review the latest commit, including the local CSS-variable sizing and retained inert behavior.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

Comment thread packages/emcn/src/components/details-panel/details-panel.tsx Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai @cubic-dev-ai Please review the latest commit. The resize calculation now includes explicit whitespace; compiled CSS and browser geometry comparisons are unchanged.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@greptileai @cubic-dev-ai Please review the latest commit. The resize calculation now includes explicit whitespace; compiled CSS and browser geometry comparisons are unchanged.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai Please run a full review of this PR against its base branch on the current head, rather than an incremental review of only the latest commit. The latest incremental review reported no issues; this is the final review of the complete change.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai Please run a full review of this PR against its base branch on the current head, rather than an incremental review of only the latest commit. The latest incremental review reported no issues; this is the final review of the complete change.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit a4730ea into staging Sep 20, 2026
37 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-details-panels branch September 20, 2026 02:09

This branch was successfully deployed

1 active deployment
Preview 849dbe45 Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants