fix(chat): return 403 for inactive chats without writing an execution log - #8024
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This was referenced Sep 19, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/chat/[identifier]on a disabled chat now returns 403 right after the chat lookup, the same asGETLoggingSessionand wrote a failedworkflow_execution_logsrow per request, before chat auth and before the execution rate limits, so anonymous callers could grow the log table and fill the owner's logs with fake failed runs at willwarnlog line stays for operatorschat-executebuckets above auth would let unauthenticated callers drain a password/email chat's execution budget (existing test asserts auth-only POSTs are not metered)Type of Change
Testing
LoggingSessionstart/complete, no auth check; confirmed it fails against the old routeapp/api/chat/**tests pass (134), lint,check:audits,docs-manifest:check, andtype-checkpassChecklist