refactor(ui): reuse shared cards for workflow inputs and variables - #8022
BillLeoutsakosvl346 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
416b32f to
f3a1d85
Compare
1d7de93 to
b16927a
Compare
|
@greptileai @cubic-dev-ai Please review the latest head after the base update. The card changes are unchanged; validation passes on the updated stack. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Before / after visual comparisonAssignment, Start/Response and variable-card shells reuse CollapsibleCard; field contents stay caller-owned. Long titles use the common fade. Each theme contains paired before/after cards, labeled in the image. Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage. Current PR head checked at posting: |
022eed8 to
0c53fa2
Compare
2d698ae to
ffd56d1
Compare
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

Variable assignments, Start/Response fields, and the Variables panel now reuse EMCN's CollapsibleCard instead of maintaining separate header/body markup. Header actions remain separate from the collapse trigger. The shared card supports the existing animated expansion and body attributes, preserving Start's Radix animation, Variables' tighter spacing, and its trigger/content association.
Colors, padding, fields, and handlers are retained. Start header corners consolidate from 3px to 4px; long titles use the existing fade/full-title tooltip treatment instead of ellipsis.
Validation: 346 EMCN tests, 67 relevant consumer tests, all workspace type and lint checks, import resolution, and mandatory API validation passed. An external AST comparison confirms all 20 affected field-control subtrees are unchanged. The scoped six radius findings are removed. Browser comparisons cover both themes, disabled/long-title cases, existing shared-card rendering, action isolation and animated keyboard collapse/reopen. Visual coverage uses isolated components with fixture fields, not live workflow execution.