Skip to content

refactor(ui): share collapsible workflow field cards - #8017

Open
BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-destructive-ghost-buttonsfrom
codex/control-fix-collapsible-field-cards
Open

BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-destructive-ghost-buttonsfrom
codex/control-fix-collapsible-field-cards

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Filter rules, sort rules, document tags and knowledge tag filters repeat the same collapsible field-card styling. Migrate them to EMCN CollapsibleCard, add a header-actions slot outside the collapse target, and forward native root attributes so workflow search can still target each row.

Card colors, borders, corners, spacing and action positions are preserved. Long titles adopt the existing fade/full-title tooltip treatment. Field controls, search highlights, refs, read-only restrictions and add/remove behavior stay in the consumers. No new visual variants are introduced.

Validation: 345 EMCN tests and 118 existing fork-sync/search-highlight tests pass, as do workspace type checks/lint, import resolution and API validation. The external audit removes all eight scoped radius findings with zero new findings. Ten light/dark fixture comparisons confirm unchanged card/body geometry and action positions, including the existing shared-card preview layout. Browser checks cover keyboard toggling and independent action clicks; full product workflow and landing integrations were not exercised. Review tooling and screenshots are outside this PR.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 8:49pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding findings or newly introduced issues since the previous review.

Summary

Refactors four workflow field-card implementations to use the shared EMCN CollapsibleCard.

  • Adds a header-actions slot outside the collapse trigger.
  • Forwards native root attributes for workflow-search selectors and accessibility metadata.
  • Preserves consumer-owned controls, highlights, read-only behavior, and add/remove actions.
  • Adds coverage for root-attribute forwarding, controlled toggling, keyboard interaction, and independent actions.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Consumers["Workflow field-card consumers"] --> Card["EMCN CollapsibleCard"]
  Card --> Root["Root attributes and search selectors"]
  Card --> Header["Header layout"]
  Header --> Trigger["Keyboard/click collapse trigger"]
  Header --> Actions["Independent action buttons"]
  Card --> Body["Expanded field controls"]
Loading

Reviews (4) · Last reviewed commit: "refactor(ui): share collapsible workflow..."

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-destructive-ghost-buttons branch from 76d44d6 to 16b81b5 Compare September 19, 2026 19:51
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-collapsible-field-cards branch from 416b32f to f3a1d85 Compare September 19, 2026 19:51
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai @cubic-dev-ai Please review the current head. The previous scored reviews predate the base update.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@greptileai @cubic-dev-ai Please review the current head. The previous scored reviews predate the base update.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Filter, sort and knowledge-tag cards reuse CollapsibleCard. The shared header uses a fade for long titles.

Each theme contains paired before/after cards, labeled in the image.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 022eed8a8f.

Before and after: cards light dark

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-destructive-ghost-buttons branch from 2b16e72 to 5e8223b Compare September 22, 2026 20:47
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-collapsible-field-cards branch from 022eed8 to 0c53fa2 Compare September 22, 2026 20:48
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview 0c53fa2c Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant