refactor(ui): share image upload preview tiles - #8015
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
 |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Contributor
Author
|
@cubic-dev-ai please re-review this PR. |
Contributor
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom block icons and organization logo/wordmark settings repeat the same upload-preview button. Move that presentation into EMCN
UploadPreviewButtonand migrate all three tiles. The component owns the empty, preview, loading and disabled appearance; callers retain file selection, upload validation, permissions, and image rendering.The 64px height, square or full-width layout, border, fill, corners, image padding and disabled opacity remain the same. Loading also exposes
aria-busy. No extra styling variants are introduced.Validation: all 345 EMCN tests, 4 existing consumer tests, workspace type checks/lint, import resolution, and API validation pass. The external conformance scan adds no findings. A browser fixture using the real component and application CSS confirms 18 matching state/theme comparisons and matching hover fills. Live upload/storage flows were not exercised; their existing logic is unchanged. Review helpers and screenshots are outside this PR.