refactor(ui): centralize destructive ghost button colors in EMCN

[BillLeoutsakosvl346]

Summary

Eleven product delete/remove buttons override EMCN Button colors locally. Add ghost-destructive (red at rest and on hover) and ghost-destructive-muted (muted at rest, red on hover) to the existing Button, and migrate all nine always-red and two muted consumers. Both use existing global color tokens.

The rendered class sets are identical. Geometry, icons, labels, handlers, disabled conditions, native button behavior and the input-format button's hover opacity remain unchanged. Existing Button variants and defaults are unchanged.

Product only: 12 source files, with landing excluded. All audit tooling and browser fixtures stay outside the branch; no dependencies or new tests.

Testing

• 343 existing EMCN tests passed; EMCN/app type checks, repository lint, API validation and git diff --check passed.
• Consumer AST comparison confirms only the variant and color classes changed at all 11 locations.
• Real before/after Button and Trash renders have identical markup after class-order normalization. 110 Chromium comparisons match in light/dark idle, hover, focus, active and disabled states using compiled app CSS. All 210 existing variant/size/padding combinations render identical markup. These are isolated component checks, not end-to-end product navigation.
• Final external category audit: 22 color overrides across 11 buttons → 0. Broader findings 1003 → 981, with unrelated findings unchanged. Full inventory still has unrelated findings and analysis gaps. Landing diff is empty.
• Committed-diff audit: zero usage violations; four expected central-definition notices for the two new color variants.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 23, 2026 2:25am UTC

[cubic-dev-ai]

No issues found across 12 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; the refactor preserves the migrated buttons’ rendered classes and interaction behavior.

Summary

The PR centralizes destructive ghost-button colors in EMCN and migrates the affected workflow and knowledge UI consumers. It also extracts the duplicated knowledge-tag summary markup into a shared component.

• Adds always-red and muted-until-hover destructive ghost variants to the shared Button CVA.
• Replaces consumer-local destructive color utilities while preserving geometry, handlers, disabled states, and accessible labels.
• Reuses KnowledgeTagRow across the document-tag and knowledge-base tag modals.

_{Reviews (3) · Last reviewed commit: "refactor(ui): centralize destructive gho..."}

[BillLeoutsakosvl346]

@greptileai @cubic-dev-ai Please review the current head. The previous scored reviews predate the base update.

[cubic-dev-ai]

@greptileai @cubic-dev-ai Please review the current head. The previous scored reviews predate the base update.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 12 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[BillLeoutsakosvl346]

Before / after visual comparison

Destructive icon actions: shared Button treatments preserve the muted/red icon colors and geometry.

Within each numbered tile: first icon = before; second icon = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 5653710ea0.

Additional theme/state comparisons

[BillLeoutsakosvl346]

@greptile

[BillLeoutsakosvl346]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 13 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}