improvement(knowledge): stop re-probing known indexing providers per access batch

[waleedlatif1]

Summary

• The search source overview iterates access batches; the source_overview.indexing probe ran in full on every batch, while the sibling searchable probe already stopped once its answer was known.
• The indexing result is only read back as set membership when projecting providers[].isSyncing, so a provider type already found cannot change the outcome. Re-probing it re-paid the query's EXISTS over document — the arm that carries the full ACL predicate — for no new information.
• Skip the probe entirely once every configured provider type is accounted for, and exclude already-found types from the query on later batches (no predicate emitted when the set is empty).
• Safe by construction: the provider list and the indexing probe build on the same configured condition, and the probe only adds narrowing predicates, so its result types are a subset of the configured ones. Excluding a found type cannot suppress a type that would otherwise be discovered — the final set, and therefore isSyncing, is identical. hasSearchableDocuments is untouched.

Type of Change

• Bug fix (performance)

Testing

• Extended search-source-overview.test.ts: a second access batch no longer re-probes once every configured type is known, and still probes while one is unaccounted for. Verified both new assertions fail when the guard is removed.
• lib/knowledge/application suite green (878 passing).
• bun run lint, check:block-registry, bun run check:audits (46), docs-manifest:check, and bun run type-check all pass. No migrations or schema changes.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 18, 2026 7:32am UTC

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; the optimization preserves the final provider syncing state while avoiding redundant queries.

Summary

This PR reduces redundant indexing-status queries while preserving the accumulated provider result.

• Stops indexing probes after every configured provider type has been found.
• Excludes provider types already found by earlier access batches.
• Adds tests covering both early termination and continued probing for unaccounted provider types.

_{Reviews (1) · Last reviewed commit: "improvement(knowledge): stop re-probing ..."}

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}