Skip to content

fix(search): isolate unavailable Calendar accounts - #7967

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/calendar-unavailable-account
Sep 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/calendar-unavailable-account

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Treat Calendar's explicit notACalendarUser response as a known per-account listing failure so unavailable accounts do not trigger the crawl-wide unknown-error pause.
  • Keep deferred retries and reconciliation safeguards, with unchanged handling for incomplete, unknown, authentication, scope, and quota errors.

Type of Change

  • Bug fix

Testing

  • Reproduced the classification failure and healthy-account starvation before the fix; both regression tests pass after it.
  • 157 focused Calendar, Google Workspace, and scheduler tests pass, including deferred-account recovery and mixed-error guards.
  • App type-check, lint, all 46 repository audits (including API boundary validation), block registry, and docs manifest checks pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 18, 2026 7:02am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the new classification is narrowly gated and preserves the scheduler’s retry and reconciliation safeguards.

Summary

This PR extends Calendar’s existing per-account failure isolation to recognize explicit notACalendarUser responses.

  • Restricts isolation to complete HTTP 403 failures from calendar.events.list.
  • Preserves propagation for incomplete, mixed, authentication, scope, quota, and unrelated failures.
  • Adds crawl-level and scheduler-level regression coverage for healthy-account progress, deferred retries, and reconciliation safety.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Calendar events list error] --> B{403 with complete non-empty reasons?}
    B -- No --> C[Propagate error]
    B -- Yes --> D{Every reason is forbidden or notACalendarUser?}
    D -- No --> C
    D -- Yes --> E[Record per-account listing failure]
    E --> F[Continue crawling healthy accounts]
    E --> G[Mark reconciliation unsafe]
    E --> H[Retry unavailable account later]
Loading

Reviews (1) · Last reviewed commit: "fix(search): isolate unavailable Calenda..."

@waleedlatif1
waleedlatif1 merged commit 89ecfc8 into staging Sep 18, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/calendar-unavailable-account branch September 18, 2026 07:05

This branch was previously deployed

1 inactive deployment
Preview e7764752 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant