Skip to content

fix(openai): preserve optional Responses tool inputs - #7953

Merged
icecrasher321 merged 1 commit into
stagingfrom
codex/preserve-optional-response-tool-inputs
Sep 18, 2026
Merged

icecrasher321 merged 1 commit into
stagingfrom
codex/preserve-optional-response-tool-inputs

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

  • Explicitly disable automatic strict normalization for Responses function tools so optional inputs remain optional, matching the declared tool schema.
  • Prevent callers from being forced to supply unrelated selectors, such as folder selection during a single-file read. Preserve tool schemas at the shared Responses adapter.

OpenAI documents that Responses attempts strict normalization when strict is omitted: https://developers.openai.com/api/docs/guides/function-calling#strict-mode

Type of Change

  • Bug fix

Testing

2,348 provider tests passed, including wrapped and flat tool-schema regressions. Application type check, lint, all 46 repository audits, and block-registry/docs checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 18, 2026 12:15am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified.

Summary

This PR updates the shared OpenAI Responses tool adapter to explicitly disable strict normalization, preserving optional fields in declared function-tool schemas.

  • Adds strict: false to converted Responses function tools.
  • Covers both wrapped and flat input definitions with regression tests.
  • Preserves the original parameters schema and required-field list.

Reviews (1) · Last reviewed commit: "fix(openai): preserve optional Responses..."

@icecrasher321
icecrasher321 merged commit 1db2a00 into staging Sep 18, 2026
34 checks passed
@icecrasher321
icecrasher321 deleted the codex/preserve-optional-response-tool-inputs branch September 18, 2026 00:21

This branch was previously deployed

1 inactive deployment
Preview 259f5c2e Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant